Skip to content

Conversation

@just-boris
Copy link
Member

Description

Port this change and some others: cloudscape-design/components#3509

Related links, issue #, if available: n/a

How has this been tested?

Run locally

PR build

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner July 11, 2025 19:28
@just-boris just-boris requested review from johannes-weber and removed request for a team July 11, 2025 19:28
await page.waitForVisible("main");

// Custom initialization.
page.init && (await page.init());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (8c840b8) to head (818d35e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          29       29           
  Lines         280      281    +1     
  Branches       34       34           
=======================================
+ Hits          278      279    +1     
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris
Copy link
Member Author

Screenshots fail because of ace library update. Syntax highlight theme changed

index-test-ts-matches-snapshot-for-code-view-with-all-features-1-snap-diff

@just-boris just-boris added this pull request to the merge queue Jul 14, 2025
Merged via the queue into main with commit 45e0dc4 Jul 14, 2025
38 of 39 checks passed
@just-boris just-boris deleted the eslint-upgrade branch July 14, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants